chore(components/config): cleanup code #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup code by using `Option::is_some_and()` and `Option::as_deref()` instead of recoding them.
Keats
approved these changes
Aug 7, 2024
| } else { | ||
| false | ||
| } | ||
| self.paginate_by.is_some_and(|paginate_by| paginate_by > 0) |
There was a problem hiding this comment.
The method name is explicit but uncommon. It is often called exists() (for example in Scala) in other functional languages, because it can be applied to construct of more than one element, such as lists, with the same semantics.
I've also seen self.paginate_by.into_iter().any(|paginate_by| paginate_by > 0) used before is_some_and() was introduced.
reujab
pushed a commit
to reujab/zola
that referenced
this pull request
Aug 14, 2024
Cleanup code by using `Option::is_some_and()` and `Option::as_deref()` instead of recoding them.
Keats
pushed a commit
that referenced
this pull request
Aug 15, 2024
Cleanup code by using `Option::is_some_and()` and `Option::as_deref()` instead of recoding them.
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
Cleanup code by using `Option::is_some_and()` and `Option::as_deref()` instead of recoding them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup code by using
Option::is_some_and()andOption::as_deref()instead of recoding them.Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?