Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for netprint #180

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Fixes for netprint #180

merged 1 commit into from
Jul 12, 2020

Conversation

matsud224
Copy link
Contributor

netprint is a printing service in Japan. We can upload files via internet and print them at seven-eleven (convenience store).
netprint doesn't accept PDFs generated by SATySFi and shows the following error:

登録エラーが発生しました。 サポートしているファイル名・ファイル形式をご確認ください。(1699)

This PR fixes this problem by suppressing null-value entries of /DW & /DW2 in Font Dictionary. /DW & /DW2 are optional entries and have integer and array type respectively. PDF 1.7 spec section 3.2.8 says:

Specifying the null object as the value of a
dictionary entry (Section 3.2.6, “Dictionary Objects”) is equivalent to omitting
the entry entirely.

Null-value entries of /DW & /DW2 may not break the specification but netprint is sensitive about it.

@gfngfn
Copy link
Owner

gfngfn commented Jul 12, 2020

I’m so sorry for the late response…

I understand the purpose for which this PR was made, read the diff, and confirmed that the modified program works well.

I’m slightly curious about how you detected that the cause of errors emit by netprint was null objects, but anyway, thank you for improvement!

@gfngfn gfngfn merged commit 666ce4d into gfngfn:master Jul 12, 2020
@matsud224 matsud224 deleted the fix-null-dw branch July 26, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants