Follow upstream change of Core #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Heap` has been renamed with `Pairing_heap` since Core v0.13. Cf. gfngfn#206
This was referenced Mar 28, 2020
|
It's found out that this fix does not work with core_kernel.v0.13.1. It's been fixed in the master 5ff61ee Closing. |
|
Thank you all the same for the suggestion of improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaphas been renamed withPairing_heapsince Core v0.13.Here is the summary of the discussion in #206.
There are two ways to workaround the incompatibility: 1) drop support of OCaml 4.07 and earlier or 2) stick at Core v0.12.
The second option implies SATySFi would be left behind development of OCaml forever. I am thus for the first option, i.e., supporting only 4.08 and later.