Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return input tensor in ggml_set_name #262

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

LoganDark
Copy link
Contributor

this is SO USEFUL for debugging. in order to find any cgraph node, I can wrap it in ggml_set_name and set a conditional breakpoint.

but I can only wrap existing code if this returns its input. otherwise the barrier becomes annoyingly high (have to move a bunch of code around to add name to a tensor)

this is SO USEFUL for debugging. in order to find any cgraph node,
I can wrap it in ggml_set_name and set a conditional breakpoint.

but I can only wrap existing code if this returns its input.
otherwise the barrier becomes annoyingly high (have to move a
bunch of code around to add name to a tensor)
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@ggerganov ggerganov merged commit 070f170 into ggerganov:master Jun 16, 2023
@LoganDark LoganDark deleted the ggml_set_name branch June 16, 2023 19:49
CCLDArjun pushed a commit to CCLDArjun/ggml that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants