Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/extend asset profile for currency #3495

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Feature/extend asset profile for currency #3495

merged 6 commits into from
Jun 22, 2024

Conversation

SirZemar
Copy link
Contributor

Closes #3488

@dtslvr dtslvr self-requested a review June 14, 2024 19:04
dtslvr
dtslvr requested changes Jun 16, 2024
View reviewed changes
Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SirZemar! 😎
I have added a few comments.

apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
dtslvr
dtslvr requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thank you. Just a few additional minor improvements 🙂

apps/api/src/app/order/order.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/order/order.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/order/order.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/admin/admin.service.ts Outdated Show resolved Hide resolved
dtslvr
dtslvr approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the adaptions, @SirZemar 👍🏻
I have tested it and slightly refactored the code. Ready to merge now.

@dtslvr dtslvr merged commit ff12124 into ghostfolio:main Jun 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtslvr dtslvr dtslvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend asset profile for currency
2 participants
@SirZemar @dtslvr