Allow explicit this parameter without renaming #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbert
reviewed
Nov 23, 2019
gilbert
reviewed
Nov 23, 2019
| } | ||
| ``` | ||
|
|
||
| Its primary use case is to play nicely with the [function bind proposal](https://github.com/zenparsing/es-function-bind), making such functions more readable. For example: |
There was a problem hiding this comment.
Suggested change
| Its primary use case is to play nicely with the [function bind proposal](https://github.com/zenparsing/es-function-bind), making such functions more readable. For example: | |
| The original motivation of this proposal was to play nicely with the [function bind proposal](https://github.com/zenparsing/es-function-bind), making such functions more readable. For example: |
There was a problem hiding this comment.
Because I'm planning revive :: notation and plan to present to committee on 2020 Feb meeting, I would like to keep the sentence. What do you think?
There was a problem hiding this comment.
You can keep the original, but you should also write about its newer applications. Here are a couple off the top of my head:
- Less transpiling required (TypeScript supports this syntax and it makes sense)
- Now that arrow functions are ubiquitous, a linter could require a named
thisfor function declarations.
There was a problem hiding this comment.
I'm not sure I understand the second point.
Co-Authored-By: Gilbert <gilbertbgarza@gmail.com>
|
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3