Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch from govendor to dep #1128

Closed
wants to merge 3 commits into from

Conversation

sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 13, 2017

dep is slated to be the official Go dependency management tool. It is ready for production use. This PR switches from govendor to dep. I also renamed the examples folders to _examples so that the dependencies are not pulled in by dep.

Packages used by examples removed from vendor:

  • github.com/dustin/go-broadcast
  • github.com/gin-gonic/autotls
  • github.com/manucorporat/stats
  • github.com/thinkerou/favicon
  • golang.org/x/crypto/acme/autocert
  • golang.org/x/sync/errgroup

Almost all other dependency revisions were changed to more recent commits:

pkg Old New
github.com/golang/protobuf 5a0f697c 130e6b02
github.com/json-iterator/go 36b14963 6240e1e7 (v1.0.3)
github.com/mattn/go-isatty 57fdcb98 0360b2af (v0.0.3)
github.com/stretchr/testify 976c720a 69483b4b (v1.1.4)
github.com/ugorji/go c88ee250 f76f59a9
golang.org/x/net/context d4c55e66 (release-branch.go1.7) a04bdaca
gopkg.in/go-playground/validator.v8 5f57d222 (v8.18.1) 5f1438d3 (v8.18.2)
gopkg.in/yaml.v2 a5b47d31 eb3733d1

Note: The revision was not changed for the package github.com/gin-contrib/sse.

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #1128 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1128   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          16       16           
  Lines        1721     1721           
=======================================
  Hits         1664     1664           
  Misses         49       49           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb68ce...ae14efe. Read the comment docs.

@appleboy
Copy link
Member

@javierprovecho @tboerger Please help to review this.

@appleboy appleboy added this to the 1.3 milestone Oct 13, 2017
Avoid pulling in any external example dependencies, when using go get.
Go tools ignore folders with names which start with `_`.
dep is a dependency management tool for Go, slated to be the official one.
@douglarek
Copy link

Maybe we should wait for vgo: https://research.swtch.com/vgo

@carllhw
Copy link

carllhw commented May 16, 2018

Any progress ?

@hellupline
Copy link

aditional info: vgo required semver tag to contain levels of version, the current 1.2 does not check in vgo
it should be at least 1.2.0

currently vgo will only match with 1.1.4

@thinkerou thinkerou mentioned this pull request Jun 25, 2018
@yushine
Copy link

yushine commented Aug 9, 2018

Any progress ?
@sudo-suhas

@javierprovecho javierprovecho modified the milestones: 1.3, 1.4 Aug 14, 2018
@sudo-suhas
Copy link
Contributor Author

Closing this PR as it is very much out of date and there is no indication that this would be accepted.

@sudo-suhas sudo-suhas closed this Aug 15, 2018
@sudo-suhas sudo-suhas deleted the chore/dep branch August 15, 2018 07:54
@thinkerou
Copy link
Member

@sudo-suhas thank you work, I think we may use vgo later on.

@thinkerou
Copy link
Member

ref #1569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants