Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fmt output log to os.Stderr #1571

Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix: fmt output log to os.Stderr #1571

merged 1 commit into from
Sep 27, 2018

Conversation

appleboy
Copy link
Member

fix #1560 changes are breaking in App Engine.

cc @giulianobr @philippgille

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1571 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1571   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          39       39           
  Lines        1929     1929           
=======================================
  Hits         1911     1911           
  Misses         14       14           
  Partials        4        4
Impacted Files Coverage Δ
debug.go 95.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834a2ec...10bfae1. Read the comment docs.

@thinkerou
Copy link
Member

have debugPrintError on debug.go file.

fmt prints to stdout, log prints to stderr.
so we may spilt two function. sorry I have no time think the idea, wait me later on.

Copy link

@giulianobr giulianobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, App Engine local development server works fine.

@appleboy appleboy merged commit 402ef12 into gin-gonic:master Sep 27, 2018
@appleboy appleboy deleted the debug branch September 27, 2018 00:59
justinfx pushed a commit to justinfx/gin that referenced this pull request Nov 3, 2018
umbynos added a commit to arduino/arduino-create-agent that referenced this pull request Dec 4, 2020
The output of GIN debug was redirected to stderr instead of stdout
umbynos added a commit to arduino/arduino-create-agent that referenced this pull request Dec 14, 2020
The output of GIN debug was redirected to stderr instead of stdout
umbynos added a commit to arduino/arduino-create-agent that referenced this pull request Dec 17, 2020
* change approach: redirect stderr to file instead using defer

* update gin dependency because of gin-gonic/gin#1571

* set default logger to stdout. (stderr is currently redirected to file)

* save crash-report to newly created `logs/` folder

* add enable/disable crash-report generation (default off)

* add entry in trayicon's menu to remove crash-reports (if there are any)

* CI polishing, add win64, update macOS min version  (#578)
umbynos added a commit to arduino/arduino-create-agent that referenced this pull request Dec 18, 2020
* change approach: redirect stderr to file instead using defer

* update gin dependency because of gin-gonic/gin#1571

* set default logger to stdout. (stderr is currently redirected to file)

* save crash-report to newly created `logs/` folder

* add enable/disable crash-report generation (default off)

* add entry in trayicon's menu to remove crash-reports (if there are any)

* CI polishing, add win64, update macOS min version  (#578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants