Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural is "Paths", not "Pathes" #1706

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

sairoutine
Copy link
Contributor

In #1677, I misspelled LoggerConfig's SkipPaths.

Note
This change breaks backward compability, but adding LoggerConfig is not released yet. This change affects only the user which is using master branch.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #1706 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1706   +/-   ##
======================================
  Coverage    99.4%   99.4%           
======================================
  Files          42      42           
  Lines        2029    2029           
======================================
  Hits         2017    2017           
  Misses          9       9           
  Partials        3       3
Impacted Files Coverage Δ
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1542eff...96016be. Read the comment docs.

@thinkerou thinkerou self-requested a review December 20, 2018 09:53
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thinkerou thinkerou merged commit 678e09c into gin-gonic:master Dec 20, 2018
@sairoutine sairoutine deleted the fix_skip_paths branch December 20, 2018 10:00
@sairoutine
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants