Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not to pass formatted string to Fprintf's format specifier parameter #1747

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Fix not to pass formatted string to Fprintf's format specifier parameter #1747

merged 1 commit into from
Jan 20, 2019

Conversation

sairoutine
Copy link
Contributor

@sairoutine sairoutine commented Jan 19, 2019 •
edited
Loading

Fix the bug of issue #1746.

PR #1677 caused it.

@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #1747 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1747   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          41       41           
  Lines        2042     2042           
=======================================
  Hits         2011     2011           
  Misses         19       19           
  Partials       12       12
Impacted Files Coverage Δ
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4867ff9...f5c1bd1. Read the comment docs.

@thinkerou thinkerou removed the request for review from appleboy January 20, 2019 00:38
@thinkerou thinkerou merged commit b4f5155 into gin-gonic:master Jan 20, 2019
@sairoutine sairoutine deleted the fix_issues_1746 branch January 20, 2019 02:34
@sairoutine
Copy link
Contributor Author

Thanks!

@sairoutine
Copy link
Contributor Author

@xuyang2
I just only missed io.WriteString.
Thanks to your pointing out, I also think it is better than fmt.Fprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sairoutine @thinkerou