-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bind http header param #1956 #1957
Merged
thinkerou
merged 8 commits into
gin-gonic:master
from
guonaihong:1956-feature-support-bind-http-header
Jun 27, 2019
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
027f846
support bind http header param #1956
guonaihong f439a1b
add unit test
guonaihong ce723d2
Modify the code to get the http header
guonaihong 159224b
Thanks to vkd for suggestions, modifying code
guonaihong c438fc1
Increase test coverage
guonaihong 8a7e38a
Rollback check code
guonaihong f9f0f9d
add use case to README.md
guonaihong adef0a8
Merge branch 'master' into 1956-feature-support-bind-http-header
appleboy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package binding | ||
|
||
import ( | ||
"net/http" | ||
"net/textproto" | ||
"reflect" | ||
) | ||
|
||
type headerBinding struct{} | ||
|
||
func (headerBinding) Name() string { | ||
return "header" | ||
} | ||
|
||
func (headerBinding) Bind(req *http.Request, obj interface{}) error { | ||
|
||
if err := mapHeader(obj, req.Header); err != nil { | ||
return err | ||
} | ||
|
||
return validate(obj) | ||
} | ||
|
||
func mapHeader(ptr interface{}, h map[string][]string) error { | ||
return mappingByPtr(ptr, headerSource(h), "header") | ||
} | ||
|
||
type headerSource map[string][]string | ||
|
||
var _ setter = headerSource(nil) | ||
|
||
func (hs headerSource) TrySet(value reflect.Value, field reflect.StructField, tagValue string, opt setOptions) (isSetted bool, err error) { | ||
return setByForm(value, field, hs, textproto.CanonicalMIMEHeaderKey(tagValue), opt) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the tag value of |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, is a good idea to add unit tests inside of
binding
package to cover it by 100% inside.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a coverage of
binding
package to 100%. (binding/header.go)This can help you:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good way,have submitted changes