This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Changed simplifyMatrix() #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only empty edges and columns will be pruned by simplifyMatrix(). This is to make it easier to compose larger form layouts and give more control to the user.
|
Nice addition, I'll do some tests and review the code and if everything works we can merge it for the 2.6 release. Thank you for the contribution! |
|
My pleasure—I hope it doesn't break everything! |
joshirio
changed the base branch from
master
to
formview-allow-empty-column-rows
|
I'm merging your work as an additional feature but leaving the current behavior as default. Thanks! And of course I'll add you to the contributors list. |
|
Happy to contribute :) |
|
Actually I think I'll make this the new default because removing free space is easy for the user, they just move a couple of widgets instead of hunting down unknown settings... Anyway an option will be provided in the settings. |
joshirio
added a commit
that referenced
this pull request
Jan 29, 2020
by default in form view, with new setting to enable auto pruning of unused space, see #120
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only empty edge-rows and edge-columns will be pruned by simplifyMatrix(). This is to make it easier to compose larger form layouts and give a bit more control to the user.
Context: I'm making a database for my small business and I was frustrated by the aggressive pruning of the form matrix columns/rows which was making it difficult to arrange the (many) widgets. Changing the pruning behaviour to only target the edges means that I can break up clusters of widgets with empty space, and I can make more working space while I experiment with the layout.
Love the software, and happy to contribute. If this change goes against your desired usage I understand completely, no bad feels.