Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toggles on preferences form #4063

Merged
merged 6 commits into from
Jun 11, 2024
Merged

fix: toggles on preferences form #4063

merged 6 commits into from
Jun 11, 2024

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jun 11, 2024 •
edited
Loading

  • Toggles on Settings <PreferencesForm /> weren't working as expected
    • Toggles in this component had both bind:isChecked and an on:click handler
  • Inlined a few other simple <Toggle /> on:click handlers

@ndom91 ndom91 merged commit 62c312c into master Jun 11, 2024
15 checks passed
@ndom91 ndom91 deleted the ndom91/preferences-checkbox branch June 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ndom91