Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve GHA code re-use #4612

Merged
merged 17 commits into from
Aug 6, 2024
Merged

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Aug 5, 2024

☕️ Reasoning

  • Improve code re-use in GHA workflows

🧢 Changes

  • Rm init-env-rust, as it was just printing version numbers for rust tooling; seems like it was once used for more, but now just left-over from debugging
  • Rm some steps from init-env-node to simplify it and make it more universally applicable
  • Use init-env-node as much as possible

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 10:05am

@ndom91 ndom91 changed the title fix: rm unused init-env-rust fix: improve GHA code re-use Aug 5, 2024
@ndom91 ndom91 force-pushed the ndom91/cleanup-shared-gha-workflows branch from 2619385 to b71e11f Compare August 5, 2024 20:12
@ndom91 ndom91 marked this pull request as ready for review August 6, 2024 09:57
@ndom91 ndom91 enabled auto-merge (squash) August 6, 2024 10:00
@ndom91 ndom91 merged commit 0ccda08 into master Aug 6, 2024
18 checks passed
@ndom91 ndom91 deleted the ndom91/cleanup-shared-gha-workflows branch August 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant