Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perl5 detected as Perl6 #2781

Closed
chorny opened this issue Dec 23, 2015 · 1 comment · Fixed by #2782
Closed

Perl5 detected as Perl6 #2781

chorny opened this issue Dec 23, 2015 · 1 comment · Fixed by #2782

Comments

@chorny
Copy link

chorny commented Dec 23, 2015

https://github.com/drzowie/Alien-Gnuplot/search?l=perl6

File is https://github.com/drzowie/Alien-Gnuplot/blob/0d4659a3687fafd79ba7aabc3a12f633e2d6ec06/Makefile.PL

IMHO, "use strict;" should be enough to classify this as Perl5.
@pchaigno pchaigno mentioned this issue Dec 24, 2015
Merged
@pchaigno
Copy link
Contributor

IMHO, "use strict;" should be enough to classify this as Perl5.

That's what we do with the heuristic strategy. However, your file matches the Perl6 heuristic first, because of the line that starts with module (the heuristic strategy is not aware of multiline comments and strings).

#2782 should fix this by reordering the heuristic for Perl. The Perl5 heuristic is more accurate than the Perl6 so I placed it before.

That said, Perl5/Perl6 classification will never be 100% accurate, because the two languages are very similar.

dbsrgits-sync pushed a commit to Perl5/DBIx-Class that referenced this issue Apr 28, 2016
@kraih @ribasushi
Silly GitHub, Perl6 is not a real language :trollface:
cab79c9 
Port of mojolicious/mojo@19cdf772
Before this clarification the project listed as 7% Perl6 code >.<

The explicit listing is needed, as there apparently won't be a fix
within Github itself any time soon:
github-linguist/linguist#2149 (comment)
github-linguist/linguist#2781 (comment)
github-linguist/linguist#2074 (comment)

Language names sourced from:
https://github.com/github/linguist/blob/master/lib/linguist/languages.yml
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorder Perl heuristic rules pchaigno/linguist
2 participants
@chorny @pchaigno