Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Mono .dll.config XML files #1922

Merged
merged 2 commits into from
Jan 2, 2015

Conversation

@arfon
Copy link
Contributor

arfon commented Dec 31, 2014

@bkeepers - this PR means we support this kind of extension now right?

@arfon
Copy link
Contributor

arfon commented Jan 1, 2015

@Mailaender - would you mind adding this example file to the samples directory?

@Mailaender
Copy link
Contributor Author

Done.

@bkeepers
Copy link
Contributor

bkeepers commented Jan 2, 2015

@bkeepers - this PR means we support this kind of extension now right?

Theoretically, but we have not added one yet, so it looks like there are still some issues with it. I'll get it fixed up.

@bkeepers bkeepers self-assigned this Jan 2, 2015
@bkeepers
Copy link
Contributor

bkeepers commented Jan 2, 2015

Fixed in #1940. If you merge master the tests should be green.

@bkeepers bkeepers removed their assignment Jan 2, 2015
@Mailaender
Copy link
Contributor Author

Rebased.

@arfon
Copy link
Contributor

arfon commented Jan 2, 2015

👍 thanks @Mailaender & @bkeepers

arfon added a commit that referenced this pull request Jan 2, 2015
Added support for Mono .dll.config XML files
@arfon arfon merged commit 71132d4 into github-linguist:master Jan 2, 2015
@arfon
Copy link
Contributor

arfon commented Jan 2, 2015

@Mailaender it will likely be another couple of weeks before this change is live on GitHub as we'll need to cut a new Linguist gem.

@Mailaender Mailaender deleted the patch-2 branch January 2, 2015 17:20
@aroben aroben mentioned this pull request Jan 7, 2015
@aroben
Copy link
Contributor

aroben commented Jan 7, 2015

This is now live on github.com.

@Mailaender
Copy link
Contributor Author

Thanks!

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants