Skip to content

Commit

Permalink
Merge pull request #1256 from github/rasmuswl/newer-virtualenv
Browse files Browse the repository at this point in the history
python-setup: Allow newest `virtualenv`
  • Loading branch information
RasmusWL authored Sep 21, 2022
2 parents 038242a + 5ffcfe9 commit c2c7bba
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions python-setup/install_tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ py -3 -m pip install --user --upgrade pip setuptools wheel

# virtualenv is a bit nicer for setting up virtual environment, since it will provide up-to-date versions of
# pip/setuptools/wheel which basic `python3 -m venv venv` won't
py -2 -m pip install --user 'virtualenv<20.11'
py -3 -m pip install --user 'virtualenv<20.11'
py -2 -m pip install --user 'virtualenv!=20.12.0'
py -3 -m pip install --user virtualenv

# We aren't compatible with poetry 1.2
py -3 -m pip install --user "poetry>=1.1,<1.2"
Expand Down
4 changes: 2 additions & 2 deletions python-setup/install_tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ python3 -m pip install --user --upgrade pip setuptools wheel

# virtualenv is a bit nicer for setting up virtual environment, since it will provide up-to-date versions of
# pip/setuptools/wheel which basic `python3 -m venv venv` won't
python3 -m pip install --user 'virtualenv<20.11'
python3 -m pip install --user virtualenv

# We install poetry with pip instead of the recommended way, since the recommended way
# caused some problem since `poetry run` gives output like:
Expand All @@ -42,5 +42,5 @@ if command -v python2 >/dev/null 2>&1; then

python2 -m pip install --user --upgrade pip setuptools wheel

python2 -m pip install --user 'virtualenv<20.11'
python2 -m pip install --user 'virtualenv!=20.12.0'
fi

0 comments on commit c2c7bba

Please sign in to comment.