Skip to content

Commit

Permalink
Merge pull request #1001 from github/henrymercer/pr-check-validate-no…
Browse files Browse the repository at this point in the history
…de-12-build

Add PR check to validate compatibility with Node 12
  • Loading branch information
henrymercer authored Mar 29, 2022
2 parents 8237e85 + 73ba7ff commit f0e2f3c
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,34 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 45

strategy:
fail-fast: true
matrix:
node-types-version: [12.12, current]

steps:
- uses: actions/checkout@v2

- name: Update version of @types/node
if: matrix.node-types-version != 'current'
env:
NODE_TYPES_VERSION: ${{ matrix.node-types-version }}
run: |
# Export `NODE_TYPES_VERSION` so it's available to jq
export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}"
contents=$(jq '.devDependencies."@types/node" = env.NODE_TYPES_VERSION' package.json)
echo "${contents}" > package.json
# Usually we run `npm install` on macOS to ensure that we pick up macOS-only dependencies.
# However we're not checking in the updated lockfile here, so it's fine to run
# `npm install` on Linux.
npm install
git config --global user.email "github-actions@github.com"
git config --global user.name "github-actions[bot]"
# The period in `git add --all .` ensures that we stage deleted files too.
git add --all .
git commit -m "Use @types/node=${NODE_TYPES_VERSION}"
- name: Check generated JS
run: .github/workflows/script/check-js.sh

Expand Down

0 comments on commit f0e2f3c

Please sign in to comment.