Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made jobs.<job_id>.steps[*].shell a separate ## #11335

Merged
merged 8 commits into from
Nov 10, 2021
Merged

Made jobs.<job_id>.steps[*].shell a separate ## #11335

merged 8 commits into from
Nov 10, 2021

Conversation

kristof-mattei
Copy link
Contributor

Why:

Separated jobs.<job_id>.steps[*].shell into its own ## which increases discoverability.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Oct 21, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review labels Oct 21, 2021
@ramyaparimi
Copy link
Contributor

@kristof-mattei
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi closed this Nov 9, 2021
@ramyaparimi ramyaparimi reopened this Nov 9, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/learn-github-actions/workflow-syntax-for-github-actions.md Modified Original

@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team label Nov 9, 2021
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great idea! Thanks for making this change. I'll get this merged down for you.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 9, 2021
@skedwards88 skedwards88 enabled auto-merge (squash) November 9, 2021 22:48
@skedwards88 skedwards88 merged commit 8965884 into github:main Nov 10, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants