Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak AWS OIDC instructions #11621

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Tweak AWS OIDC instructions #11621

merged 4 commits into from
Nov 30, 2021

Conversation

aripollak
Copy link
Contributor

@aripollak aripollak commented Nov 2, 2021 •
edited
Loading

Why:

Closes #11534

What's being changed:

  • Only contents: read is necessary
  • Remove :aud filter because it's set to "sts.amazonaws.com" when using aws-actions/configure-aws-credentials

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@aripollak
Tweak AWS OIDC instructions
c5089f7 
* Only contents: read is necessary
* Remove :aud filter because it's set to "sts.amazonaws.com" when using aws-actions/configure-aws-credentials
@welcome
Copy link

welcome bot commented Nov 2, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 3, 2021
@ramyaparimi
Copy link
Contributor

@aripollak
Thanks so much for opening a PR! I'll get this triaged for review ⚡

hubwriter
hubwriter approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aripollak - Many thanks for raising this PR.
I'll get this merged/published for you.
🚀

@hubwriter hubwriter merged commit ba382b2 into github:main Nov 30, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Anmar1988260 Anmar1988260 mentioned this pull request Nov 4, 2022
Open
@oudomskn oudomskn mentioned this pull request Nov 4, 2022
Open
@vutting4221 vutting4221 mentioned this pull request Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2022
Open
@francissimo francissimo mentioned this pull request Nov 4, 2022
Open
@ramsemune ramsemune mentioned this pull request Nov 4, 2022
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Nov 4, 2022
Open
@machatman machatman mentioned this pull request Nov 4, 2022
Open
@taeb3 taeb3 mentioned this pull request Nov 4, 2022
Open
@Manny27nyc Manny27nyc mentioned this pull request Nov 4, 2022
Open
@pinpc pinpc mentioned this pull request Nov 4, 2022
Open
@shats15 shats15 mentioned this pull request Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Nov 5, 2022
Open
@arroselli arroselli mentioned this pull request Oct 15, 2024
Open
@Jccp1983 Jccp1983 mentioned this pull request Oct 15, 2024
Open
@tglt-9794 tglt-9794 mentioned this pull request Oct 15, 2024
Open
@w124578 w124578 mentioned this pull request Oct 15, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Oct 15, 2024
Open
@chrisjcox79 chrisjcox79 mentioned this pull request Oct 16, 2024
Open
@zipzip225 zipzip225 mentioned this pull request Oct 16, 2024
Open
@shga1993 shga1993 mentioned this pull request Oct 16, 2024
Open
@mohammad-84 mohammad-84 mentioned this pull request Oct 16, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Oct 16, 2024
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Oct 16, 2024
Open
@rudaruda0 rudaruda0 mentioned this pull request Oct 16, 2024
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Oct 16, 2024
Open
@bitokenja3 bitokenja3 mentioned this pull request Oct 16, 2024
Open
@Jccp1983 Jccp1983 mentioned this pull request Oct 16, 2024
Open
@symoriarayford symoriarayford mentioned this pull request Oct 16, 2024
Open
@irinazheltisheva irinazheltisheva mentioned this pull request Oct 17, 2024
Open
@amymariaparker2401 amymariaparker2401 mentioned this pull request Oct 17, 2024
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Oct 17, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Oct 17, 2024
Open
@bonachylauriel bonachylauriel mentioned this pull request Oct 17, 2024
Open
@rhsayem075 rhsayem075 mentioned this pull request Oct 18, 2024
Open
@rexiliano89 rexiliano89 mentioned this pull request Oct 18, 2024
Open
@makombelajob makombelajob mentioned this pull request Oct 18, 2024
Open
@ariafilda ariafilda mentioned this pull request Oct 18, 2024
Open
@machatman machatman mentioned this pull request Oct 18, 2024
Open
@roru78 roru78 mentioned this pull request Oct 18, 2024
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Oct 18, 2024
Open
@kyawburma kyawburma mentioned this pull request Oct 18, 2024
Open
@monzerfoda monzerfoda mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OIDC w/ AWS example doesn't appear to be valid JSON
3 participants
@aripollak @ramyaparimi @hubwriter