Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs to be more explanatory #1256

Closed
wants to merge 3 commits into from
Closed

Improve docs to be more explanatory #1256

wants to merge 3 commits into from

Conversation

avinal
Copy link
Contributor

@avinal avinal commented Nov 11, 2020

Why:

Fixes #974

What's being changed:

  • Added {:copy} snippet to all code snippets
  • Improved Dockerfile snippet to make scripts executable here
# Container image that runs your code
FROM alpine:3.10
# Copies your code file from your action repository to the filesystem path `/` of the container
COPY entrypoint.sh /entrypoint.sh
# Makes your code file executable
RUN chmod +x entrypoint.sh
# Code file to execute when the docker container starts up (`entrypoint.sh`)
ENTRYPOINT ["/entrypoint.sh"]
  • Removed a step here because it was unclear, this step is now covered by the previous change,

Check off the following:

@welcome
Copy link

welcome bot commented Nov 11, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor Author

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@janiceilene
Copy link
Contributor

@avinal Thanks so much for opening a PR! I'll get this triaged for review 🌟

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 21, 2020
@avinal
Copy link
Contributor Author

avinal commented Nov 22, 2020

Is there more to add to this pr?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 22, 2020
@janiceilene
Copy link
Contributor

There's nothing you need to add @avinal! Thanks for your patience as our small team works through all of the amazing contributions 🌟

@avinal
Copy link
Contributor Author

avinal commented Nov 23, 2020

Thanks, @janiceilene for confirmation.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 6, 2020
@medoahmammmm

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More details for newbies
4 participants