Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explanation about hashFiles returning an empty string #15719

Merged
merged 4 commits into from
Mar 3, 2022

Conversation

nikola-jokic
Copy link
Contributor

Why:

Closes #15717, Relates to actions/runner issue

What's being changed:

I just added one sentence explaining that if the path does not match any known path, an empty string would be returned

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 22, 2022
@nikola-jokic nikola-jokic changed the title Update expressions.md Added explanation about hashFiles returning an empty string Feb 22, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Feb 22, 2022
@ramyaparimi
Copy link
Contributor

@nikola-jokic
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Co-authored-by: Edward Thomson <ethomson@github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/learn-github-actions/expressions.md Modified Original

@ethomson
Copy link
Contributor

ethomson commented Mar 2, 2022

Great. Thanks for digging in to the https://github.com/actions/runner repository and turning that into really meaningful improvements. This is great stuff @nikola-jokic

ethomson
ethomson previously approved these changes Mar 2, 2022
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I just made one minor wording suggestion. I'll go ahead and incorporate that, then we'll get this merged down for you.

content/actions/learn-github-actions/expressions.md Outdated Show resolved Hide resolved
@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 3, 2022
@skedwards88 skedwards88 enabled auto-merge (squash) March 3, 2022 00:22
@skedwards88 skedwards88 merged commit 087c91e into github:main Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@nikola-jokic nikola-jokic deleted the patch-4 branch March 3, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashFiles() may output empty string when patterns are not matched is not documented
4 participants