Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving issues#20289 - part 1/2 - adding a sentence as requested #20805

Merged
merged 7 commits into from
Sep 26, 2022

Conversation

CapitainFlam
Copy link
Contributor

Why:

Closes [https://github.com//issues/20289]

What's being changed (if available, include any code snippets, screenshots, or gifs):

According to UI product feedback, I added a sentence at the end.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 23, 2022
@CapitainFlam CapitainFlam changed the title Patch 1 solving issues#20289 - part 1/2 - adding a sentence as requested Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

felicitymay
felicitymay previously approved these changes Sep 26, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CapitainFlam - thank you for taking the time to submit this update to fix issue #20289

I've updated your wording so that it's suitable for all our products and moved the new text above the list of maximum file sizes so that it's easier to see. I will merge your change once the tests pass.

@felicitymay felicitymay enabled auto-merge (squash) September 26, 2022 08:10
@felicitymay felicitymay linked an issue Sep 26, 2022 that may be closed by this pull request
1 task
@felicitymay felicitymay merged commit dbbbf1b into github:main Sep 26, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@CapitainFlam CapitainFlam deleted the patch-1 branch September 26, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Attaching files' has missing important note
2 participants