Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds warning for 2fa users during org transfers #22634

Merged
merged 4 commits into from
Dec 15, 2022
Merged

adds warning for 2fa users during org transfers #22634

merged 4 commits into from
Dec 15, 2022

Conversation

scarletspiderfan
Copy link
Contributor

@scarletspiderfan scarletspiderfan commented Dec 13, 2022 •
edited
Loading

Adds a warning to let admins know that non-2FA accounts will be removed during an org transfer where the new enterprise enforces a 2FA requirement.

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

I added a warning to the section for transferring organizations between enterprise accounts.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@scarletspiderfan
adds warning for 2fa
8c22996 
Adds a warning to let admins know that non-2FA accounts will be removed during an org transfer where the new enterprise enforces a 2FA requirement.
@welcome
Copy link

welcome bot commented Dec 13, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/user-management/managing-organizations-in-your-enterprise/adding-organizations-to-your-enterprise.md ghec
 ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Chiefy0x1

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Contributor

👋 @scarletspiderfan - Thanks for opening a PR and linking it to your issue ⚡

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team administering a repo Content relating to administering a repo enterprise Content relating to GitHub Enterprise organizations Content related to organizations waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team administering a repo Content relating to administering a repo labels Dec 13, 2022
lecoursen
lecoursen reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @scarletspiderfan! This information would fit best in the "About addition of organizations to your enterprise account" section of this article, in the list of changes that apply after adding an existing organization your enterprise. Can you please move it there? Thanks!

@scarletspiderfan
Copy link
Contributor Author

hi @lecoursen, I've removed the warning and added it to the top of the list instead. 👍

lecoursen
lecoursen previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scarletspiderfan! I'll apply some small suggestions and then merge. ⚡

...agement/managing-organizations-in-your-enterprise/adding-organizations-to-your-enterprise.md Outdated Show resolved Hide resolved
...agement/managing-organizations-in-your-enterprise/adding-organizations-to-your-enterprise.md Outdated Show resolved Hide resolved
@lecoursen lecoursen merged commit 40b4495 into github:main Dec 15, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise organizations Content related to organizations waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Adding organizations to your enterprise" does not warn about problems with transferring non-2fa accounts
4 participants
@scarletspiderfan @Chiefy0x1 @cmwilson21 @lecoursen