Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo #23004

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fixing a typo #23004

merged 4 commits into from
Jan 6, 2023

Conversation

nhoizey
Copy link
Contributor

@nhoizey nhoizey commented Jan 5, 2023 •
edited
Loading

I don't think the past tense should be used here, even if the example just after doesn't apply this recommendation and uses lower camel case…

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@nhoizey
Fixing a typo
e914c55 
I don't think the past tense should be used here, even if the example just after doesn't apply this recommendation and uses lower camel case…
@cmwilson21
Copy link
Contributor

@nhoizey Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Jan 5, 2023
@nhoizey
Copy link
Contributor Author

nhoizey commented Jan 5, 2023

@cmwilson21 you're welcome.

I didn't check the "I have reviewed my changes in staging" checkbox because I don't understand what I should do, sorry.

sophietheking
sophietheking approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @nhoizey, this looks good to me! Thanks for fixing this and contributing to our Docs. 💖 I've approved this PR and will get this merged for you.

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 5, 2023
@nhoizey
Copy link
Contributor Author

nhoizey commented Jan 5, 2023

@sophietheking you're welcome! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/creating-actions/metadata-syntax-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 merged commit 4c3932f into github:main Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhoizey @cmwilson21 @sophietheking