Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base permissions docs to explicitly state changes impact new & existing customers. #24145

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Update base permissions docs to explicitly state changes impact new & existing customers. #24145

merged 3 commits into from
Mar 2, 2023

Conversation

adamrr724
Copy link
Contributor

@adamrr724 adamrr724 commented Feb 24, 2023 •
edited by cmwilson21
Loading

Why:

Closes #24144

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding a note that states base permissions changes take effect on both new and existing customers.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
organizations/managing-user-access-to-your-organizations-repositories/setting-base-permissions-for-an-organization.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @adamrr724 Thanks for opening an issue and submitting a PR! I edited your PR slightly, removing the word ISSUE after the Closes prompt to link the PR to the issue. 👍

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review organizations Content related to organizations and removed triage Do not begin working on this issue until triaged by the team labels Feb 28, 2023
sophietheking
sophietheking previously approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrr724 👋 thanks for opening this PR! I left a suggestion to update the note slightly.

Please feel free to @mention me here to get this merged!

...er-access-to-your-organizations-repositories/setting-base-permissions-for-an-organization.md Outdated Show resolved Hide resolved
@sophietheking sophietheking removed the waiting for review Issue/PR is waiting for a writer's review label Mar 1, 2023
@adamrr724 @sophietheking
Update content/organizations/managing-user-access-to-your-organizatio…
56fee24 
…ns-repositories/setting-base-permissions-for-an-organization.md

Co-authored-by: Sophie <29382425+sophietheking@users.noreply.github.com>
@adamrr724
Copy link
Contributor Author

Hi @sophietheking! All committed and ready for merge. Thank you so much!

@sophietheking sophietheking merged commit b58c327 into github:main Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team organizations Content related to organizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly state that changes to base permissions impact both new and existing members.
3 participants
@adamrr724 @cmwilson21 @sophietheking