Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional cleanup step after failover to HA replica #252

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

mwiesen
Copy link
Contributor

@mwiesen mwiesen commented Oct 8, 2020

Why:

With the current documentation a failover will be completed and access to the GitHub Enterprise Server will be restored, however a configuration cleanup will not be performed.

This means that Spokes, DPages, and Storage will maintain references to the old (potentially inaccessible) servers yet will be unable to replicate any data to them. This can and will eventually lead to clone/push failures and full repository outages should those servers not be re-added as replicas.

Solves https://github.com/github/docs-content/issues/2564

What's being changed:

Our current documentation outlines the high-level steps to perform a failover, however more detail is needed clarifying follow-up actions in the event that that the primary server and/or other replicas will not be re-added to the GitHub Enterprise Server configuration.

I added a new (optional) step following the current step 7 noting the UUIDs of any servers which will not be re-added to the environment should be cleaned up by running ghe-repl-teardown -u <uuid_here>.

Check off the following:

@maclarel
@myarb

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mwiesen mwiesen requested a review from myarb October 8, 2020 08:48
@mwiesen mwiesen self-assigned this Oct 8, 2020
@mwiesen mwiesen added the content This issue or pull request belongs to the Docs Content team label Oct 8, 2020
@janiceilene
Copy link
Contributor

Thanks for opening a PR @mwiesen! I'll let the @github/docs-content-core team know it's ready for review 💝

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to ensure that the example command appears in full, otherwise the change looks great 💖

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge once the formatting of the example command is fixed 😄

@felicitymay felicitymay removed the request for review from myarb October 20, 2020 12:09
@felicitymay
Copy link
Contributor

Hi @mwiesen - I'm not sure if you saw my comment on this pull request. From your really clear description of the problem this change addresses, I'm keen to resolve the problem so that we can merge this PR and your improvement to the docs will be live.

If don't hear from you before Monday, October 26, I'll commit my fix and merge this change.

Copy link
Contributor Author

@mwiesen mwiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that @felicitymay !

…our-replica-appliance.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felicitymay
Copy link
Contributor

Updated from main. Once the tests complete, this should be ready to merge.

@felicitymay felicitymay merged commit 0bccf58 into main Oct 23, 2020
@felicitymay felicitymay deleted the mwiesen-failover-cleanup branch October 23, 2020 11:18
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymay felicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
```
- On the new primary, remove the UUIDs using `ghe-repl-teardown`. Please replace *`UUID`* with a UUID you retrieved in the previous step.
```shell
$ ghe-repl-teardown -u <em>UUNID</em>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/UUNID/UUID/ small typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure why this only just popped up in my notifications given it was merged a month ago. I'll open a new PR to fix the typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants