Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'master' branch labels to 'main' #349

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Change 'master' branch labels to 'main' #349

merged 3 commits into from
Oct 9, 2020

Conversation

Two4
Copy link
Contributor

@Two4 Two4 commented Oct 9, 2020

Why:

Following the guide leads a confusing extra non-default 'master' branch on new repositories

What's being changed:

instructions lead to files being pushed to 'main' instead of 'master' on Windows/Linux (Mac already changed as of this PR)

Check off the following:

  • [x ] All of the tests are passing.
  • [ x] I have reviewed my changes in staging.
  • [x ] For content changes, I have reviewed the localization checklist
  • [x ] For content changes, I have reviewed the Content style guide for GitHub Docs.
    I've actually done none of these, it's literally a two word change. MWAHAHAHA

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR @Two4! I'll update this branch and merge once all the tests are green 🍏

@janiceilene janiceilene merged commit 009ccda into github:main Oct 9, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@Two4 Two4 deleted the patch-1 branch October 12, 2020 04:17
This was referenced Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants