Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple deploy keys #501

Merged
merged 20 commits into from
Nov 13, 2020
Merged

Multiple deploy keys #501

merged 20 commits into from
Nov 13, 2020

Conversation

tarrenj
Copy link
Contributor

@tarrenj tarrenj commented Oct 13, 2020

Adds instructions on defining unique ssh keys (deploy keys) per repo on one server by using the ssh config file.

Why:

#500

What's being changed:

image

Check off the following:

Adds instructions on defining unique ssh keys (deploy keys) per repo on one server by using the ssh config file.
@welcome
Copy link

welcome bot commented Oct 13, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @tarrenj! I'll get this triaged for review ✨

@janiceilene janiceilene added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team content This issue or pull request belongs to the Docs Content team labels Oct 14, 2020
@tarrenj
Copy link
Contributor Author

tarrenj commented Oct 14, 2020

Found and fixed a small typo, sorry if this bounces it back into Triage!

@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
@martin389
Copy link
Contributor

martin389 commented Nov 10, 2020

@tarrenj - thanks so much for creating this PR! 🎉

I've added some small edits to the draft, just to suit our existing docs conventions. Could you check that you're happy with my suggestions? 👍

You can find the rendered preview here: https://docs-501--multiple-deploy-keys.herokuapp.com/en/free-pro-team@latest/developers/overview/managing-deploy-keys#using-multiple-repositories-on-one-server

@tarrenj
Copy link
Contributor Author

tarrenj commented Nov 10, 2020

@martin389

I've added some small edits to the draft, just to suit our existing docs conventions. Could you check that you're happy with my suggestions? 👍

They look good to me! I used this existing page as a reference, so that's another discrepancy for you guys to be aware of.

@martin389
Copy link
Contributor

Checked with the folks from support, and they're happy with this draft 🎉

@martin389 martin389 linked an issue Nov 11, 2020 that may be closed by this pull request
@martin389
Copy link
Contributor

Now doing some readiness checks.

Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some versioning for the different page versions is probably needed, plus a few suggestions to clarify the behavior.

content/developers/overview/managing-deploy-keys.md Outdated Show resolved Hide resolved
content/developers/overview/managing-deploy-keys.md Outdated Show resolved Hide resolved
content/developers/overview/managing-deploy-keys.md Outdated Show resolved Hide resolved
content/developers/overview/managing-deploy-keys.md Outdated Show resolved Hide resolved
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Unique Deployment Keys on One Server.
4 participants