Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a step to configure the publish scope. #7299

Merged
merged 6 commits into from
Jun 28, 2021
Merged

Conversation

radfahrer
Copy link
Contributor

@radfahrer radfahrer commented Jun 11, 2021

Why:

There is a missing step.
Closes #7298

What's being changed:

Adds missing step.

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

I was not able to get this to work until I updated my .npmrc
@welcome
Copy link

welcome bot commented Jun 11, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 11, 2021
@janiceilene
Copy link
Contributor

@radfahrer Thanks so much for opening a PR! I'll get this triaged for review 💖

@janiceilene janiceilene added packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 11, 2021
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this omission from the quickstart guide and adding instructions for how to fix it. 💖

I'm a packages novice and tried the quick start guide with and without your step. I would have been baffled about how to fix this on my own. With your changes I was able to work it out 🙂

content/packages/quickstart.md Outdated Show resolved Hide resolved
content/packages/quickstart.md Show resolved Hide resolved
@felicitymay
Copy link
Contributor

Apologies for the delay in getting to your review, it's been a busy time. I'm going to check that my text changes look okay on staging when it finishes deploying: https://docs-7299--patch-2.herokuapp.com/en/packages/quickstart. As long as I haven't introduced any bugs, I'll update the branch from main and merge your changes.

Thank you so much for taking the time to raise this PR to fix this omission in the quickstart ✨

@felicitymay felicitymay enabled auto-merge (squash) June 28, 2021 23:34
@felicitymay felicitymay merged commit f9d0110 into github:main Jun 28, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing step for setting publish scope in packages/quickstart.md
3 participants