Gather REPLICA tablet types from Vitess only #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drogart
approved these changes
Apr 22, 2020
jfudally
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Vitesssupport to only consider
REPLICAtablet types for probingToday this logic gathers any host available, including nodes that probably shouldn't get checked like
MASTER,DRAINED,SPARE,BACKUP,RESTORE, etc. It can be valid for non-REPLICAs to have lagThe full list of tablet types available is here: https://godoc.org/vitess.io/vitess/go/vt/proto/topodata#TabletType
The
REPLICAtablet-type is described as:EDIT:
go modis pulling in a v.2.1.1 version of the Vitess package I used, due to this issue here: vitessio/vitess#5019. I only use 1 x API struct so I think it's ok