Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrate repo logged download logs instructions #1182

Merged

Conversation

tspascoal
Copy link
Contributor

When a repo is migrated the logs contain instructions how to download the logs, but the parameters names were incorrect.

Only gei since download-logs parameters are not consistent between gei, bbs2gh´ and ado2gh(onlygei` is different than the other two)

closes #1179

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

When a repo is migrated the logs contain instructions how to download the logs, but the parameters names were incorrect.
Copy link

github-actions bot commented Dec 6, 2023

Unit Test Results

791 tests   791 ✔️  22s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit e64dd63.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@timrogers timrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to RELEASENOTES.md too, actually? Maybe something like:

Fix suggested command for downloading logs in gh gei migrate-repo log output

@tspascoal
Copy link
Contributor Author

Can you add this to RELEASENOTES.md too, actually? Maybe something like:

Fix suggested command for downloading logs in gh gei migrate-repo log output

Added in e64dd63

Copy link

github-actions bot commented Dec 6, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
ado2gh 84% 79% 613
bbs2gh 78% 73% 644
Octoshift 85% 75% 1246
gei 78% 70% 510
Summary 82% (6639 / 8065) 74% (1498 / 2014) 3013

@tspascoal tspascoal changed the title Fix Generate repo logged download logs instructions Fix migrate repo logged download logs instructions Dec 6, 2023
@timrogers timrogers merged commit 142c9f8 into github:main Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download logs instruction in logs have wrong parameters
2 participants