Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uploading eslint sarif for dependabot PR #3726

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Sep 23, 2024

Dependabot does not have security-events: write permission.

See github/codeql-action#2485 for the original instance of this problem.

Dependabot does not have `security-events: write` permission.
@aeisenberg aeisenberg requested a review from a team as a code owner September 23, 2024 19:15
@aeisenberg
Copy link
Contributor Author

Hmmm...unsure why the CI jobs are failing. Looks like it is failing on main as well. https://github.com/github/vscode-codeql/actions/runs/10994181318/job/30522243194#step:7:95

@aeisenberg
Copy link
Contributor Author

aeisenberg commented Sep 24, 2024

Bumping the timeout worked.

Feels a little lazy, but if you're ok with it, so am I.

@aeisenberg aeisenberg merged commit b6b707e into main Sep 24, 2024
16 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/no-upload-sarif branch September 24, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants