Merge pull request microsoft#468 from microsoft/samart/allowEventShor…

…thand

allowing event to be called with only value

packages/clarity-js/src/data/custom.ts

@@ -4,15 +4,20 @@ import encode from "./encode";
 
 export let data: CustomData = null;
 
-export function event(key: string, value: string): void {
+// custom events allow 2 parameters or 1 parameter to be passed. If 2 are passed we
+// consider it a key value pair. If only 1 is passed we only consider the event to have a value.
+export function event(a: string, b: string): void {
     if (core.active() &&
-        key &&
-        value &&
-        typeof key === Constant.String &&
-        typeof value === Constant.String &&
-        key.length < 255 &&
-        value.length < 255) {
-        data = { key, value};
-        encode(Event.Custom);
+        a &&
+        typeof a === Constant.String &&
+        a.length < 255
+        ) {
+            if (b && typeof b === Constant.String && b.length < 255) {
+                data = { key: a, value: b};
+            } else {
+                data = { value: a }
+            }
+            encode(Event.Custom);
+
     }
 }

packages/clarity-js/src/data/encode.ts

@@ -53,7 +53,8 @@ export default function(event: Event): void {
             queue(tokens, false);
             break;
         case Event.Custom:
-            tokens.push(custom.data.key);
+            // not all custom events have a key - if it wasn't passed server handles just value
+            custom.data.key && tokens.push(custom.data.key);
             tokens.push(custom.data.value);
             queue(tokens);
             break;

packages/clarity-js/types/data.d.ts

@@ -407,7 +407,7 @@ export interface VariableData {
 // The way it's different from variable is that Custom Event has a notion of time
 // Whereas variables have no timing element and eventually will turn into custom dimensions
 export interface CustomData {
-    key: string;
+    key?: string;
     value: string;
 }