Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Websocket is not reconnectable in iframe #3847

Closed
AlexTugarev opened this issue Apr 8, 2021 · 0 comments
Closed

[dashboard] Websocket is not reconnectable in iframe #3847

AlexTugarev opened this issue Apr 8, 2021 · 0 comments
Assignees

Comments

@AlexTugarev
Copy link
Member

Bug description

When not being logged in to Gitpod and trying to access a URL of a running workspace you will see the login page, but after signing in with OAuth you will stay on the login page.

Steps to reproduce

  1. Start a workspace and copy it's URL
  2. open a clean browser session (where you are not logged in at that time) and try to access the workspace URL
  3. try to login

Expected behavior

After a successful login, you would be able to access your workspace from a clean browser session.

Example repository

No response

Details

  • When not being logged in to Gitpod and trying to access a URL of a running workspace the websocket is created in the supervisor frontend instead of the regular dashboard parts.
  • Supervisors frontend is not prepared for reconnecting websockets (Websocket reconnect not possible is logged)
  • Also it seems there were related changes merged to gitpod-protocol in the meantime which needs to be considered.

Workaround

  • forcibly reload the browser tab (with the workspace URL) after the login in order to recreate the websocket connection

/cc. @akosyakov

MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 9, 2021
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this issue Aug 16, 2021
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this issue Aug 16, 2021
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants