Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: connect via ssh devx improvement #10394

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Jun 1, 2022

Description

Feedback from @anaisbetts that the string that is copied to the clipboard may contain characters which are processed by shells such as bash. By single quoting the connection string this is prevented.

Screen Shot 2022-06-01 at 3 38 23 pm

How to test

I made this change in the GitHub editor and have not tested this change.

Release Notes

dashboard: single quote connect via ssh connection string

Documentation

@ghuntley ghuntley requested a review from a team June 1, 2022 05:40
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 1, 2022
@roboquat roboquat merged commit 7d07951 into main Jun 1, 2022
@roboquat roboquat deleted the gh/copy-paste-devx branch June 1, 2022 07:47
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants