Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code from GitpodServerLauncher and update JetBrains backend-plugin to work when user has proxies #11307

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Jul 12, 2022

Description

Clean code from GitpodServerLauncher and update JetBrains backend-plugin to work when the user has proxies.

This reverts the hotfix from #11232 and passes a default SslContextFactory to HttpClient, which the root cause of the issue #11228. For reference, this is the error message the server was triggering:

java.lang.IllegalStateException: HttpClient has no SslContextFactory, wss:// URI's are not supported in this configuration
at io.gitpod.gitpodprotocol.api.GitpodServerLauncher.listen

Related Issue(s)

Resolves #11291

How to test

Release Notes

Gitpod Plugin for JetBrains IDEs was updated to properly handle network proxies.

Documentation

None.

Werft options:

  • /werft with-preview

@felladrin felladrin marked this pull request as ready for review July 12, 2022 17:06
@felladrin
Copy link
Contributor Author

felladrin commented Jul 12, 2022

I wasn't able to run gpctl workspaces last-heartbeat command from the preview environment (as instructed in the "How to test" section), but I confirm the workspace was up for almost two hours, meaning the refactoring succeeded. So I'm setting it as Ready for Review.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did not try, but code changes looks good.

/hold

if someone wants to test, if not please merge

@akosyakov
Copy link
Member

I wasn't able to run gpctl workspaces last-heartbeat command

just look at logs and see what JB backend can connect to Gitpod API

@akosyakov
Copy link
Member

Screenshot 2022-07-13 at 13 40 48

/unhold

@roboquat roboquat merged commit de67bd4 into main Jul 13, 2022
@roboquat roboquat deleted the felladrin/11291 branch July 13, 2022 11:42
@felladrin felladrin removed the request for review from mustard-mh July 13, 2022 15:16
@roboquat roboquat added the deployed: IDE IDE change is running in production label Jul 14, 2022
@roboquat roboquat added the deployed Change is completely running in production label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the Gitpod Server Launcher [Follow-up from #11232]
3 participants