Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getDocumentationLink() in GitpodConnector #13811

Closed
wants to merge 1 commit into from
Closed

Change getDocumentationLink() in GitpodConnector #13811

wants to merge 1 commit into from

Conversation

whytrall
Copy link

Description

This PR removes deprecated API

Related Issue(s)

Should fix https://youtrack.jetbrains.com/issue/GTW-1976

How to test

  1. Open Gateway
  2. Click on More button

Release Notes

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@whytrall whytrall requested a review from a team October 12, 2022 15:28
@roboquat
Copy link
Contributor

@whytrall: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 14, 2022

Thanks @whytrall! ✨ Could you resolve conflicting files here? 🙏

@whytrall You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

@felladrin Could you take a look at this since you added this part back in #8917 or pass this to someone on the team? 🏀

@akosyakov
Copy link
Member

@andreafalzetti @felladrin does it still make sense or already fixed on main?

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Oct 19, 2022

Thanks for the contribution @whytrall 🙏

As we discussed, we will close this PR in favour of #13966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants