Deactivate team scope selector on personal usage #14238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/werft run with-preview with-payment 👍 started the job as gitpod-build-gt-deactivate-team-scope-selector.1 |
jankeromnes
reviewed
Oct 27, 2022
components/dashboard/src/Menu.tsx
Outdated
| @@ -110,6 +110,7 @@ export default function Menu() { | |||
| "keys", | |||
| "integrations", | |||
| "preferences", | |||
| "usage", | |||
There was a problem hiding this comment.
Nit: I personally find it easier when the order of URLs is roughly aligned with the order in menus 😇 would you mind adding "usage" right below "billing"? 👀
There was a problem hiding this comment.
Good point! 🙂
Moved and pushed again in cc460a6.
Thanks for taking a look, @jankeromnes! 🏀
jankeromnes
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Looks good to me, many thanks @gtsiolis! 🙌
/hold for one minor, optional nit
gtsiolis
force-pushed
the
gt/deactivate-team-scope-selector
branch
from
82b8263
to
cc460a6
Compare
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up from #14161, this will make sure the team scope selector becomes deactivated when visiting personal usage. See relevant discussion (internal).
Related Issue(s)
Fixes #13968
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide