Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of Feedback emojis #16292

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Reverse order of Feedback emojis #16292

merged 1 commit into from
Feb 8, 2023

Conversation

atduarte
Copy link
Contributor

@atduarte atduarte commented Feb 8, 2023

Description

Currently the emoji order is from good to bad which seems weird.

Before Change

This PR changes it go from bad to good. This change can have an impact on scores.

See relevant discussion (internal). Cc @mbrevoort @chrifro

Related Issue(s)

N/A

Release Notes

NONE

@roboquat
Copy link
Contributor

roboquat commented Feb 8, 2023

@atduarte: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atduarte atduarte marked this pull request as ready for review February 8, 2023 10:22
@atduarte atduarte requested a review from a team February 8, 2023 10:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 8, 2023
@atduarte atduarte changed the title Change order of Feedback emojis Reverse order of Feedback emojis Feb 8, 2023
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atduarte for taking a bias for action by opening this and @easyCZ for taking a look!

Updated the PR description to include the release notes section and a link back to the internal discussion for reference and visibility. 🏓

LET'S DO THIS.

we-are-going-outside

@roboquat roboquat merged commit 5b96bc0 into main Feb 8, 2023
@roboquat roboquat deleted the atduarte-patch-1 branch February 8, 2023 10:37
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants