[gp] track git event with instanceId #16693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of workspaceInstanceId to allow cross events matching in Mixpanel
akosyakov
commented
Mar 6, 2023
| @@ -76,6 +80,7 @@ var gitTrackCommand = &cobra.Command{ | |||
| log.WithField("command", gitTrackCommandOpts.GitCommand). | |||
| Info("tracking the GitCommand event") | |||
|
|
|||
| // TODO(ak) use segment directly + supervisor info to get workspace and isntance IDs, don't use server | |||
There was a problem hiding this comment.
it is for future, not sure what would be consequence of moving to another source, i.e. from trusted to untrusted.
For Mixpanel there are none, not sure about other reports. cc @jakobhero @loujaybee
jeanp413
approved these changes
Mar 6, 2023
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
instead of workspaceInstanceId to allow cross events matching in Mixpanel
Related Issue(s)
Fixes #
How to test
git_commanevent withinstanceIdproperty matching to instance id fromgp info.Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh