Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace <SelectIDE /> with <SelectIDEComponent /> #16847

Merged
merged 19 commits into from
Mar 24, 2023
Merged

Replace <SelectIDE /> with <SelectIDEComponent /> #16847

merged 19 commits into from
Mar 24, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 14, 2023 •
edited
Loading

Description

Replaces the IDE selection cards with the dropdown adopted in contexts like the user onboarding and the new workspace modal.

This also removes the onboarding "Select IDE" modal, because that is now a part of the new onboarding flow.

Related Issue(s)

Fixes #13116

How to test

Take a look at it at https://filiptroni9852fbf578.preview.gitpod-dev.com/user/preferences

Release Notes

NONE
Before After
image image

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-filiptronicek-replace-the-editor-13116.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/M and removed size/XS labels Mar 14, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-filiptronicek-replace-the-editor-13116.3 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/XL and removed size/M labels Mar 14, 2023
@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 14, 2023 •
edited by github-actions bot
Loading

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4420402817

  • recreate_vm: true

@roboquat roboquat added size/L and removed size/XL labels Mar 14, 2023
@filiptronicek filiptronicek self-assigned this Mar 15, 2023
@filiptronicek filiptronicek marked this pull request as ready for review March 15, 2023 19:43
@filiptronicek filiptronicek requested a review from a team March 15, 2023 19:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 15, 2023
@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 15, 2023 •
edited by github-actions bot
Loading

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4430455566

  • recreate_vm: true

@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 15, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-filiptronicek-replace-the-editor-13116.15
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-filiptronicek-replace-the-editor-13116.16 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-filiptronicek-replace-the-editor-13116.17 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @filiptronicek! 🌮 🌮

Left two minor issue comments we can tackle also in a separate PR.

Approving to unblock merging, but holding in case you'd like to address the issue comments in this PR. 🏓

/hold

components/dashboard/src/user-settings/SelectIDE.tsx
<PillLabel type="neutral" className="place-self-start py-0.5 my-2 flex">
<span className="text-xs normal-case font-medium">{option.label}</span>

{shouldShowJetbrainsNotice && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: ✨

components/dashboard/src/user-settings/SelectIDE.tsx
style={{
minHeight: "1rem",
<div className="w-112 my-4">
<SelectIDEComponent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Flawless!

components/dashboard/src/user-settings/SelectIDE.tsx Show resolved Hide resolved
components/dashboard/src/user-settings/SelectIDE.tsx Show resolved Hide resolved
gtsiolis
gtsiolis approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM! 🌮 🌮

@easyCZ easyCZ force-pushed the filiptronicek/replace-the-editor-13116 branch from 6f40073 to d3beb14 Compare March 17, 2023 07:56
@filiptronicek filiptronicek force-pushed the filiptronicek/replace-the-editor-13116 branch from f2a98ec to 896ff38 Compare March 23, 2023 19:35
@filiptronicek filiptronicek removed the request for review from a team March 23, 2023 19:35
@filiptronicek filiptronicek mentioned this pull request Mar 23, 2023
Closed
20 tasks
selfcontained
selfcontained approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for going the extra mile and updating it to use react-query too 👍

@selfcontained
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 0c08926 into main Mar 24, 2023
@roboquat roboquat deleted the filiptronicek/replace-the-editor-13116 branch March 24, 2023 16:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 30, 2023
@filiptronicek filiptronicek mentioned this pull request Apr 12, 2023
Merged
20 tasks
@filiptronicek filiptronicek mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@selfcontained selfcontained selfcontained approved these changes

Assignees

@filiptronicek filiptronicek

Labels
component: dashboard deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: IDE team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: In Validation
Milestone
No milestone
5 participants
@filiptronicek @gtsiolis @selfcontained @roboquat @easyCZ