Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix werft triggered workspace integration tests #16908

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Mar 17, 2023

Description

The integration tests are optimized to run in werft. They stopped working this week. We are migrating to Github Actions in #16904, but, it is not stable yet.

This fixed werft, and unblocks our ability to deploy with certainty / makes it less likely that we'll introduce regressions to production. These tests are cross cutting, and use components from other teams (webapp and IDE).

Related Issue(s)

Fixes # n/a

How to test

  1. assert we cant trigger tests, like so:
werft run github -j ./.werft/workspace-run-integration-tests.yaml \
-a with-integration-tests=workspace \
-a with-large-vm=true \
-a with-gce-vm=true \
-a with-werft=true
  1. observe we have two broken tests! 😬:
--- FAIL: TestGitHubContexts/context/should_run_context_tests/github.com/atduarte/lfs-test_classic (110.02s)
--- FAIL: TestOpenWorkspaceFromOutdatedPrebuild/prebuild/it_should_open_a_workspace_from_with_an_older_prebuild_initializer_successfully_and_run_the_init_task/classic (19.42s)

Broke tests to be fixed in a follow-on PR.

  1. assert preview environments (GCE preferred) still work, by browsing to the one for this branch

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-kylos101-debug-wks-integ.3 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101 kylos101 self-assigned this Mar 17, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-kylos101-debug-wks-integ.4 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-kylos101-debug-wks-integ.5 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-kylos101-debug-wks-integ.6 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101
Copy link
Contributor Author

/hold

to assert that the GCE preview environment works. it's building/creating now.

@kylos101 kylos101 marked this pull request as ready for review March 17, 2023 20:22
@kylos101 kylos101 requested review from a team March 17, 2023 20:22
@kylos101
Copy link
Contributor Author

/unhold
preview environment works ✔️

@kylos101
Copy link
Contributor Author

@vulkoingim @mads-hartmann is there anything else you'd recommend I test as part of this change?

@roboquat roboquat merged commit a295beb into main Mar 21, 2023
@roboquat roboquat deleted the kylos101/debug-wks-integ branch March 21, 2023 08:08
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note-none size/XS team: security-infrastructure-and-delivery team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants