Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry-facade] do not log node-labeler inquires as errors #17099

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Mar 30, 2023

Description

Avoid logging node-labeler checks on registry-facade as an error. This will help reduce noise when inspecting a running cluster.

Related Issue(s)

Fixes # n/a

How to test

Observe this log.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-kylos101-not-a-valid-image.2 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101 kylos101 mentioned this pull request Mar 30, 2023
13 tasks
@kylos101 kylos101 marked this pull request as ready for review March 30, 2023 21:36
@kylos101 kylos101 requested a review from a team March 30, 2023 21:36
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 30, 2023
@roboquat roboquat merged commit e292a59 into main Mar 31, 2023
@roboquat roboquat deleted the kylos101/not-a-valid-image branch March 31, 2023 09:02
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants