Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fetch User based on JWT Session sub #17710

Merged
merged 1 commit into from
May 24, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 23, 2023

Description

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ requested a review from a team May 23, 2023 11:26
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 23, 2023
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@geropl
Copy link
Member

geropl commented May 24, 2023

Whoops, wasn't the first one - should have reloaded my tab first 🙃

@easyCZ
Copy link
Member Author

easyCZ commented May 24, 2023

/unhold

@roboquat roboquat merged commit e481eb9 into main May 24, 2023
@roboquat roboquat deleted the mp/server-jwt-sess-fetch-user branch May 24, 2023 12:41
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants