Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin search alert copy #17760

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

Description

Minor copy update for the search alert in /admin.

Follow-up from #17754. Cc @svenefftinge @AlexTugarev @geropl

How to test

  1. Go to /admin/blocked-email-domains
  2. Notice the search alert copy mentions the email domain URL, not the repository URL.

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@gtsiolis gtsiolis requested a review from a team May 26, 2023 09:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 26, 2023
@gtsiolis
Copy link
Contributor Author

Thanks for taking a look, @easyCZ. 🌮 🌮

/unhold

@roboquat roboquat merged commit ed420a4 into main May 26, 2023
@roboquat roboquat deleted the gt/update-admin-search-alert-copy branch May 26, 2023 11:04
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants