validate jb warmup #18050
Merged
validate jb warmup #18050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/hold
size/M
size/L
size/XL
and removed
size/M
size/L
labels
akosyakov
force-pushed
the
ak/validate_jb_warmup
branch
from
85ed3eb
to
781a0d7
Compare
akosyakov
force-pushed
the
ak/validate_jb_warmup
branch
from
781a0d7
to
3f27877
Compare
akosyakov
force-pushed
the
ak/validate_jb_warmup
branch
2 times, most recently
from
c72c93f
to
3725fb2
Compare
akosyakov
commented
Jun 28, 2023
| @@ -490,9 +490,9 @@ func (s *IDEServiceServer) ResolveWorkspaceConfig(ctx context.Context, req *api. | |||
| resp.IdeSettings = ideSettingsEncoded.String() | |||
| } | |||
|
|
|||
| // TODO figure out how to make it configurable on IDE level, not hardcoded here | |||
| jbGW, ok := ideConfig.IdeOptions.Clients["jetbrains-gateway"] | |||
| if req.Type == api.WorkspaceType_PREBUILD && ok { | |||
There was a problem hiding this comment.
prebuilds are not working right now anyway, so we don't make it backward compatible
akosyakov
force-pushed
the
ak/validate_jb_warmup
branch
13 times, most recently
from
0a37ba8
to
1a86c8c
Compare
akosyakov
force-pushed
the
ak/validate_jb_warmup
branch
from
1a86c8c
to
8cd3514
Compare
akosyakov
commented
Jun 29, 2023
| @@ -490,9 +490,9 @@ func (s *IDEServiceServer) ResolveWorkspaceConfig(ctx context.Context, req *api. | |||
| resp.IdeSettings = ideSettingsEncoded.String() | |||
| } | |||
|
|
|||
| // TODO figure out how to make it configurable on IDE level, not hardcoded here | |||
There was a problem hiding this comment.
we deal with it later, it will need some kind of metadata configuration in the image itself that we can compare it against .gitpod.yml and configs here and decide
|
@iQQBot Could you have a look at it please? I would like to land it and proceed with actual troubleshooting of JB warmups in production 🙏 |
iQQBot
approved these changes
Jun 29, 2023
|
/unhold |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extract JB warmup task configuration from server to JB integration itself to enable usage of
gp validateto investigate warmup issues in the regular workspace. Composition of IDE prebuild tasks are done by supervisor, i.e. it can detect multiple desktop IDEs now.Related Issue(s)
A prerequisite to IDE-182
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold