Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Assert cgroup v2 is enabled #18064

Merged
merged 1 commit into from
Jul 3, 2023
Merged

[test] Assert cgroup v2 is enabled #18064

merged 1 commit into from
Jul 3, 2023

Conversation

WVerlaek
Copy link
Member

Description

Fail cgroupv2 test if v2 is not enabled

Related Issue(s)

Fixes WKS-270

How to test

cd test
go test -v ./... -run TestCgroupV2

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@WVerlaek WVerlaek requested a review from a team June 26, 2023 16:04
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 26, 2023
kylos101
kylos101 approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call failing the test otherwise. 👍

@WVerlaek
Copy link
Member Author

WVerlaek commented Jul 3, 2023

/unhold

@roboquat roboquat merged commit 1d147d4 into main Jul 3, 2023
@roboquat roboquat deleted the wv/test-assert-cgroup-v2 branch July 3, 2023 08:33
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WVerlaek @kylos101 @roboquat