Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scrubber go module dependency #18149

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Cleanup scrubber go module dependency #18149

merged 1 commit into from
Jul 4, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 3, 2023 •
edited
Loading

Description

We should not have versioned dependencies for components.
That usually means we have at least one missing replace directive in a go.mod file.

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@aledbf aledbf requested review from a team July 3, 2023 19:19
@aledbf aledbf requested a review from a team as a code owner July 3, 2023 19:19
kylos101
kylos101 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mads-hartmann
mads-hartmann approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roboquat roboquat merged commit 57c605d into main Jul 4, 2023
38 of 40 checks passed
@roboquat roboquat deleted the aledbf/cleanup-scrubber branch July 4, 2023 08:37
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production labels Jul 5, 2023
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

@kylos101 kylos101 kylos101 approved these changes

@easyCZ easyCZ easyCZ approved these changes

@akosyakov akosyakov akosyakov approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production size/L team: IDE team: security-infrastructure-and-delivery team: staff-engineers team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aledbf @mads-hartmann @kylos101 @easyCZ @akosyakov @geropl @roboquat