Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[werft] Make cert creation & helm installation sequential #4729

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

princerachit
Copy link
Contributor

@princerachit princerachit commented Jul 7, 2021

Werft deployments are broken due to some bug in one of the dependencies. Since we install dependencies without pinning them one of the transitive dependencies could be an issue.

We see that await keyword is not returning the promise as expected, therefore, for now we are installing gitpod sequentially followed by certificate installation.

@princerachit princerachit marked this pull request as ready for review July 7, 2021 12:23
@princerachit princerachit requested a review from a team as a code owner July 7, 2021 12:23
@princerachit princerachit requested review from akosyakov, geropl, csweichel and meysholdt and removed request for a team July 7, 2021 12:23
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@princerachit princerachit merged commit 11c7ac4 into main Jul 7, 2021
@princerachit princerachit deleted the prs/werft-fix-node branch July 7, 2021 13:00
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this pull request Dec 2, 2021
…4729)

* Make cert creation & helm installation sequential

* Fix sleep in cert.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants